Double and Triple Click Selection

[carlos-zamora]

Summary of the Pull Request

Initial double click selection works. So a double click will make a selection within some preset delimiters (' ', '/' '\'). The left side excludes the delimiter. The right side includes it.

Initial triple click selection works. Selects the entire line.

The following known issues will be implemented in separate PRs.
Known Issues:

• ChunkSelection: move mouse after a double/triple click to select next chunk (section between delimiters)
• Double Click Settings (Multi-Click Selection: Double-Click Settings #1273 ): configurable delimiters, enable chunk selection, set bounds as inclusive/exclusive

References

#1084 Screenshot Selection: one step closer to this. Now just need to create it and attach it as a configurable option to triple click
#988 Double Click Selection: needs ChunkSelection + Settings before completion
#989 Triple Click Selection: needs ChunkSelection + Settings before completion

PR Checklist

• Doesn't close issue. Please read above.
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

TermControl Changes

• Actually detect Double and Triple Click.
• TIMESTAMP created to keep track of time delta for double/triple click (couldn't find a XAML way to do this :( )

Terminal Changes

• Triple Click:
  • pretty straightforward. No delimiter check necessary.
• Double Click:
  • if double click a delimiter, just select that spot
  • otherwise, expand selection to the left and right (each have their own function)
  • Delimiter check hardcodes space and slashes. This is super temporary because I'll replace it when delimiters are configurable in settings.

Validation Steps Performed

You can actually do most with the header on startup :).

• Double Click first word in header
• Double Click any other word in header
• Triple Click any line

[miniksa]

There's one odd thing with the triple click check that I want to see your answer to before signing off.

[carlos-zamora]

Once #1273 gets merged in, I'm gonna do a bit of refactoring too. I want to move most/all of the changes in Terminal.cpp to TerminalSelection.cpp

[miniksa]

Approved, but please fix the seconds/milliseconds comment mismatch before merging.

[DHowett-MSFT]

yes please

[ghost]

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download