[Functional-Command Palette] - Case sensitive commands in Russian localization

[whatsupbros]

User Experience:
Users of Russian Windows localization can be confused, because commands are case sensitive. So, "Новая вкладка" ("New tab") command cannot be found with "новая" ("new") input string in lowercase, but can be found with "Новая" ("New"), which preserves the case.

Test Environment:
App: Windows Terminal 1.7.1033.0
Feature: Command Palette
OS: Microsoft Windows [Version 10.0.19042.928]

Repro Steps:

1. Open Windows terminal app
2. Open Command Palette using shortcut (ctrl+shift+p)
3. Search for New tab command in the search field in Russian, use "новая" search string for this and see the empty result:
   
4. Now use "Новая" instead, see the different result
   

Expected:
Commands in Command Pallete to be case insensitive.
In fact, commands should be findable in English also, even is Russian localization of the OS.

So, both "new" or "новая" search strings should find "Новая вкладка" command (which is Russian translation for "New tab").

[Don-Vito]

@Zza - thanks for reporting.

It looks that we added locale aware case-sensitivity for commands sorting, but not for command filtering. Inside FilteredCommand::_computeHighlightedName we have:

const auto lowerCaseSearchChar = std::towlower(searchChar);
...
auto isCurrentCharMatched = std::towlower(commandName[currentOffset]) == lowerCaseSearchChar;

In the code above std::towlower uses default locale that for some reason is not Russian locale.

[Don-Vito]

Forgot to mention, that the trivial fix is to use the same approach we have for sorting (lstrcmpi) to compare chars.
(There are other approaches, but I think this one is both trivial and robust).

@zadjii-msft - please assign this to me (hope to fix it later on).

[Don-Vito]

OK.. it was kinda "one-liner", so I did it, though didn't test it in Russian.

[ghost]

🎉This issue was addressed in #9943, which has now been successfully released as Windows Terminal v1.8.1444.0.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉This issue was addressed in #9943, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

• Release Notes
• Store Download