Only attempt to focus if there is a control to focus #11040
Conversation
ghost
added
Area-User Interface
|
@zadjii-msft I know you assigned it to yourself, but I'm sure you're busy being a team lead instead of dealing with my bugs. |
|
@msftbot merge this in 7 minutes and make sure @zadjii-msft signs off |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
@msftbot merge this in 1 minute |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
Only focus if there is a control to focus (which may be null if e.g. the focused tab is being destroyed) Closes #11037 ## Additional comments I tried to remove the _activePane = nullptr in `TerminalTab::DetachPane` but that actually completely broke being able to focus the control at all making the tab completely unusable. Focus does seem to transfer just fine here with this change. ## Validation Steps Performed Used the command execution to move panes to and from existing panes, including new tabs and destroying tabs.
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
Only focus if there is a control to focus (which may be null if e.g. the focused tab is being destroyed)
Closes #11037
Additional comments
I tried to remove the _activePane = nullptr in
TerminalTab::DetachPanebut that actually completely broke being able to focus the control at all making the tab completely unusable. Focus does seem to transfer just fine here with this change.Validation Steps Performed
Used the command execution to move panes to and from existing panes, including new tabs and destroying tabs.