Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a file for storing elevated-only state #11222

Merged
merged 43 commits into from Nov 13, 2021
Merged

Add a file for storing elevated-only state #11222

merged 43 commits into from Nov 13, 2021

Commits on Sep 14, 2021

  1. This is everything from dev/migrie/f/non-terminal-content-elevation-w… 

    …arning for specifically ElevatedState

(cherry picked from commit 97b0f06)
    @zadjii-msft
    zadjii-msft committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    6be6972 View commit details
    Browse the repository at this point in the history

  2. 🤦 

    (cherry picked from commit 00c7647)
    @zadjii-msft
    zadjii-msft committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    c106f64 View commit details
    Browse the repository at this point in the history

  3. minor nits 

    (cherry picked from commit 306ad30)
    @zadjii-msft
    zadjii-msft committed Sep 14, 2021
    1 Configuration menu
    Copy the full SHA
    51e0473 View commit details
    Browse the repository at this point in the history

  4. todo! in the code

    @zadjii-msft
    zadjii-msft committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    da0cc7b View commit details
    Browse the repository at this point in the history

  5. bunch of new allowed words

    @zadjii-msft
    zadjii-msft committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    4e69a32 View commit details
    Browse the repository at this point in the history

  6. fix the tests

    @zadjii-msft
    zadjii-msft committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    6757452 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. blindly remove ElevatedState

    @zadjii-msft
    zadjii-msft committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    a4acdeb View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    5685063 View commit details
    Browse the repository at this point in the history

  3. remove baseapplicationstate and just merge it back in

    @zadjii-msft
    zadjii-msft committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9b3b9e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    507a48e View commit details
    Browse the repository at this point in the history

  2. this is a crazy idea that I hate but gotta start somewhere

    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b1b1bef View commit details
    Browse the repository at this point in the history

  3. I think this works ALMOST as I want 

      * [x] delete all state, open terminal elevated - generated profiles go to the correct place, approved commandlines go to the elevated one.
  * [x] delete some dynamic profiles, open the terminal - they don't resurrect in either IL
  * [ ] GAH saving a window layout unelevated, then trying to save one elevated will blow away the unelevated one
    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    7e2e4ea View commit details
    Browse the repository at this point in the history

  4. Move window state, approvedCommandlines into user-state.json 

      This fixes the issue I had in the last commit. It's a little weird, but gets
  rid of the muckiness of layering. Things that are local to one elevation level
  won't pollute the other, and we don't need to worry about layering or where
  they came from. Just write shared state to `state.json`, and window state to
  `elevated-state`/`user-state`
    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f3738f5 View commit details
    Browse the repository at this point in the history

  5. pr nits

    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    a6e044d View commit details
    Browse the repository at this point in the history

  6. fix hot reloading for this file

    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    1 Configuration menu
    Copy the full SHA
    eee657b View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    1 Configuration menu
    Copy the full SHA
    02e9871 View commit details
    Browse the repository at this point in the history

  8. okay so I guess that's not a word

    @zadjii-msft
    zadjii-msft committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    5ff9a24 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2

  Tossed out the AppState changes from #11083, since we're planning on just
  moving that to the Monarch anyways.
    @zadjii-msft
    zadjii-msft committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    620ee30 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    d053f6c View commit details
    Browse the repository at this point in the history

  2. This seemingly works the way I'd expect, going to merge into the warn… 

    …ing dialog and check
    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    866832b View commit details
    Browse the repository at this point in the history

  3. cleanup

    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    b4e0496 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev/migrie/f/just-trying-something-on-just-elevated-sta… 

    …te-2' into dev/migrie/f/just-elevated-state-2
    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    1 Configuration menu
    Copy the full SHA
    9ff2775 View commit details
    Browse the repository at this point in the history

  5. Add some logging. Can't seem to get the crash to repro?

    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    1 Configuration menu
    Copy the full SHA
    48b20de View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/dev/migrie/b/1.12-crash-on-exit'… 

    … into dev/migrie/f/investigate-crashing
    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    3c1866a View commit details
    Browse the repository at this point in the history

  7. we want this

    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    aea3752 View commit details
    Browse the repository at this point in the history

  8. Merge commit 'aea37520b3cdb1c1752a6c8e0ff598991518ce28' into dev/migr… 

    …ie/f/just-elevated-state-2
    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    1 Configuration menu
    Copy the full SHA
    0e7217d View commit details
    Browse the repository at this point in the history

  9. teh

    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    1 Configuration menu
    Copy the full SHA
    ae99ce9 View commit details
    Browse the repository at this point in the history

  10. spel is hard

    @zadjii-msft
    zadjii-msft committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    bf3c6e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    faa06f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    945c81d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    9b4ae9e View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. this is a collection of the trivial nits while I wait on a reply to t… 

    …he hard questions
    @zadjii-msft
    zadjii-msft committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    4976a09 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. trying to do the thing eryksun mentioned. This seems to actually work… 

    … to prevent non-admins from writing the file, and BOY is it simple. Still doesn't prevent the vim situation, but also do we need to prevent that footgun? probably
    @zadjii-msft
    zadjii-msft committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    fd849a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. this works really quite well

    @zadjii-msft
    zadjii-msft committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    25b2675 View commit details
    Browse the repository at this point in the history

  2. this is the right way to initialize the unique_hlocal_security_descri… 

    …ptor
    @zadjii-msft
    zadjii-msft committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    b212871 View commit details
    Browse the repository at this point in the history

  3. many comments

    @zadjii-msft
    zadjii-msft committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    4f16dfb View commit details
    Browse the repository at this point in the history

  4. I believe this is the rest of the comments

    @zadjii-msft
    zadjii-msft committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    a93d17e View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Nov 9, 2021
    1 Configuration menu
    Copy the full SHA
    ce6a9c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. spell

    @zadjii-msft
    zadjii-msft committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    db9cbf3 View commit details
    Browse the repository at this point in the history

  2. the last of it?

    @zadjii-msft
    zadjii-msft committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    08cbd16 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/just-ele… 

    …vated-state-2
    @zadjii-msft
    zadjii-msft committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    999f21f View commit details
    Browse the repository at this point in the history

  2. mitigate a TOCTOU

    @zadjii-msft
    zadjii-msft committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    33e96e7 View commit details
    Browse the repository at this point in the history

  3. dustins nits

    @zadjii-msft
    zadjii-msft committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7f03d4d View commit details
    Browse the repository at this point in the history