Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to PGO Nuget #11819

Merged
27 commits merged into from
Dec 15, 2021
Merged

Move to PGO Nuget #11819

27 commits merged into from
Dec 15, 2021

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented Nov 24, 2021

To unify with WinUI, we're going to share an engineering component of this particular NuGet package full of scripts and utilities to make PGOing things easier.

This basically removes all of the scripts that I blatantly stole copied from https://github.com/microsoft/microsoft-ui-xaml and moves to the NuGet package that the team generates instead. A bunch of build things had to be massaged to make it work in our pipeline.

@miniksa miniksa marked this pull request as ready for review November 30, 2021 22:53
@miniksa miniksa changed the title [DRAFT] move to pgo nuget Move to PGO Nuget Nov 30, 2021
@miniksa miniksa added this to the Engineering Improvements 2021 milestone Nov 30, 2021
@miniksa miniksa added the Area-Build Issues pertaining to the build system, CI, infrastructure, meta label Nov 30, 2021
@miniksa miniksa added Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. labels Nov 30, 2021
src/cascadia/WindowsTerminal_UIATests/Common/PgoManager.cs Outdated Show resolved Hide resolved
@@ -10,6 +10,8 @@
<clear />
</disabledPackageSources>
<config>
<!-- TODO: TEMPORARY UNTIL PGO-Helpers is updated to search both. We shouldn't need to keep the globals path here. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bare TODO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on @dkbennett to fix the package on this one.

cc: @kmahone

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @bartekk8 is what I actually meant... Sorry.

build/pgo/Terminal.PGO.props Outdated Show resolved Hide resolved
build/pipelines/release.yml Show resolved Hide resolved
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I'm only not signing off because of the dev/miniksa/pgo thing. Fix that and :shipit:

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 26911c2 into main Dec 15, 2021
@ghost ghost deleted the dev/miniksa/pgo branch December 15, 2021 14:56
miniksa added a commit that referenced this pull request Jan 10, 2022
To unify with WinUI, we're going to share an engineering component of this particular NuGet package full of scripts and utilities to make PGOing things easier.

This basically removes all of the scripts that I ~blatantly stole~ copied from https://github.com/microsoft/microsoft-ui-xaml and moves to the NuGet package that the team generates instead. A bunch of build things had to be massaged to make it work in our pipeline.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants