The InputStateMachine should dispatch Intermediate characters #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the input state machine to not collect intermediate chars
zadjii-msft
added
Product-Conpty
adiviness
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The OutputStateMachine needs to collect "Intermediate" characters to be able to call
Designate G0 Character Set(as well as other sequences we don't yet support).However, the InputStateMachine used by conpty to process input should not collect these characters. The input engine uses
\x1bas an indicator that a key was pressed withAlt. For keys like/, we want to dispatch the key immediately, instead of collecting it and leaving us in the Escape state.PR Checklist