New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force the bundle major version to be over 3000 #12819
Conversation
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0. After #12691, it became the same as the build of Terminal it contained. This caused some trouble for _some_ systems: major version 1 is much, much smaller than 2022. Adding 3000 to the major version component, _only for the bundle_, gets around this. Ugh. Fixes #12816.
build/pipelines/release.yml
Outdated
|
||
$Files | % { Move-Item -Verbose $_.Directory $_.Directory.Parent.Parent -EA:Ignore } | ||
pwsh: true | ||
# - task: TouchdownBuildTask@1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NFCI commit, will be reverted
This reverts commit a27ff31.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a risk that using this version number will fail because it is
thousands of numbers less than "2022". We'll have to see if the store
rolls it out properly
Narrator: it did not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gross.
@msftbot merge this in 1 minute |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0. After #12691, it became the same as the build of Terminal it contained. This caused some trouble for _some_ systems: major version 1 is much, much smaller than 2022. Adding 3000 to the major version component, _only for the bundle_, gets around this. Ugh. Fixes #12816. (cherry picked from commit bc6bf15) Service-Card-Id: 80144497 Service-Version: 1.13
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0. After #12691, it became the same as the build of Terminal it contained. This caused some trouble for _some_ systems: major version 1 is much, much smaller than 2022. Adding 3000 to the major version component, _only for the bundle_, gets around this. Ugh. Fixes #12816. (cherry picked from commit bc6bf15) Service-Card-Id: 80144496 Service-Version: 1.12
🎉 Handy links: |
🎉 Handy links: |
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0.
After #12691, it became the same as the build of Terminal it contained.
This caused some trouble for some systems: major version 1 is much,
much smaller than 2022.
Adding 3000 to the major version component, only for the bundle, gets
around this. Ugh.
Fixes #12816.