AtlasEngine: Stop resizing buffers on scroll #13100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
|
Turns out ad2358d isn't in 1.14 (I think?) so it doesn't need to be backported. |
|
I think that commit is in 1.14. We should tag this one up. |
carlos-zamora
approved these changes
May 16, 2022
lhecker
added
the
AutoMerge
|
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
approved these changes
May 17, 2022
ghost
merged commit 
carlos-zamora
moved this from To Cherry Pick
to Cherry Picked
in 1.14 Servicing Pipeline
carlos-zamora
pushed a commit
that referenced
this pull request
May 17, 2022
This regressed in ad2358d. We're interested in the size of the viewport only, but it can shift up/down during scrolling. In these situations we shouldn't resize our buffers of course. ## Validation Steps Performed * Scroll * Not setting `ApiInvalidations::Size` ✅ (cherry picked from commit fa6b066) Service-Card-Id: 82005202 Service-Version: 1.14
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in ad2358d.
We're interested in the size of the viewport only, but it can shift up/down
during scrolling. In these situations we shouldn't resize our buffers of course.
Validation Steps Performed
ApiInvalidations::Size✅