Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the scrollbar postiton on scrollToMark #13291

Merged
3 commits merged into from
Jun 16, 2022

Commits on Jun 13, 2022

  1. Update the scrollbar postiton on scrollToMark

    When I moved this into ControlCore, I forgot that UserScrollViewport is usually triggered by the scrollbar updating, so it doesn't ask the UI to update. Since this logic is in ControlCore, it's sorta in a weird place where it needs to communicate both up and down:
    * update the `Terminal`'s viewport position
    * update the `TermControl`'s scrollbar position
    
    * [x] Closes a bug bash bug
    zadjii-msft committed Jun 13, 2022
    1 Configuration menu
    Copy the full SHA
    13d48a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd28a8b View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Update src/cascadia/TerminalControl/ControlCore.cpp

    Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
    zadjii-msft and carlos-zamora committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    246cc9d View commit details
    Browse the repository at this point in the history