Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema with scroll marks actions and settings #13414

Merged
merged 1 commit into from Jul 1, 2022
Merged

Update schema with scroll marks actions and settings #13414

merged 1 commit into from Jul 1, 2022

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jul 1, 2022 •
edited by carlos-zamora

Summary of the Pull Request

Update schema with the settings/actions added in #12948

PR Checklist

@ghost ghost added Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels Jul 1, 2022
@carlos-zamora carlos-zamora added this to To Cherry Pick in 1.15 Servicing Pipeline via automation Jul 1, 2022
@PankajBhojwani PankajBhojwani added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 1, 2022
@carlos-zamora
Copy link
Member

@PankajBhojwani schema changes don't automerge 😭

@carlos-zamora carlos-zamora merged commit 478c2c3 into main Jul 1, 2022
@carlos-zamora carlos-zamora deleted the dev/pabhoj/marks_schema branch July 1, 2022 21:24
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.15 Servicing Pipeline Jul 5, 2022
DHowett pushed a commit that referenced this pull request Jul 5, 2022
@PankajBhojwani @DHowett
Update schema with scroll marks actions and settings (#13414)
2fdcd4e 
Update schema with the settings/actions added in #12948

## PR Checklist
* [x] Closes #13404
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Schema updated.

(cherry picked from commit 478c2c3)
Service-Card-Id: 83790285
Service-Version: 1.15
@ghost
Copy link

ghost commented Jul 6, 2022

🎉Windows Terminal Preview v1.15.186 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 6, 2022
Closed
@TBBle TBBle mentioned this pull request Jul 23, 2022
Closed
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.15 Servicing Pipeline Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.
Projects
No open projects
1.15 Servicing Pipeline
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll marks missing from JSON schema
3 participants
@PankajBhojwani @carlos-zamora @lhecker