Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenHere: stop failing if there's no site... #14211

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Oct 13, 2022

It cannot be known why there is no site.
We should at least not crash.

Fixes MSFT-41571451

@DHowett DHowett added this to To Cherry Pick in 1.15 Servicing Pipeline via automation Oct 13, 2022
@DHowett DHowett added this to To Cherry Pick in 1.16 Servicing Pipeline via automation Oct 13, 2022
@DHowett DHowett merged commit 18e4e22 into main Oct 14, 2022
@DHowett DHowett deleted the dev/duhowett/openhere-some-more branch October 14, 2022 19:32
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.15 Servicing Pipeline Oct 14, 2022
DHowett added a commit that referenced this pull request Oct 14, 2022
It cannot be known why there is no site.
We should at least not crash.

Fixes MSFT-41571451

(cherry picked from commit 18e4e22)
Service-Card-Id: 86206545
Service-Version: 1.15
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.16 Servicing Pipeline Oct 14, 2022
DHowett added a commit that referenced this pull request Oct 14, 2022
It cannot be known why there is no site.
We should at least not crash.

Fixes MSFT-41571451

(cherry picked from commit 18e4e22)
Service-Card-Id: 86206546
Service-Version: 1.16
@ghost
Copy link

ghost commented Oct 18, 2022

🎉Windows Terminal v1.15.2874 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant