Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant tooltips from settings UI #14244

Merged
2 commits merged into from Oct 24, 2022

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

This removes all of the redundant tooltips from the settings UI. Since all of the settings are added through the SettingsContainer, it's a pretty simple change.

Closes #14184

Validation Steps Performed

  • hover over all settings in the settings UI
  • hover over all entries in the SUI nav view

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Oct 17, 2022
@@ -1585,4 +1557,4 @@
<value>Set as default</value>
<comment>Text label for a button that, when invoked, sets the selected color scheme as the default scheme to use.</comment>
</data>
</root>
</root>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you saved this with a text editor, you may need to go re-save it with Visual Studio ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah! Already did via VS! I know better than that :P

@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Oct 19, 2022
@ghost ghost requested review from zadjii-msft and PankajBhojwani October 19, 2022 17:27
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 24, 2022
@DHowett DHowett added this to To Cherry Pick in 1.15 Servicing Pipeline via automation Oct 24, 2022
@DHowett DHowett added this to To Cherry Pick in 1.16 Servicing Pipeline via automation Oct 24, 2022
@ghost
Copy link

ghost commented Oct 24, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 3eaa781 into main Oct 24, 2022
@ghost ghost deleted the dev/cazamor/sui/remove-redundant-tooltips branch October 24, 2022 19:38
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.15 Servicing Pipeline Dec 1, 2022
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.16 Servicing Pipeline Dec 1, 2022
DHowett pushed a commit that referenced this pull request Dec 1, 2022
This removes all of the redundant tooltips from the settings UI. Since all of the settings are added through the SettingsContainer, it's a pretty simple change.

Closes #14184

- [X] hover over all settings in the settings UI
- [X] hover over all entries in the SUI nav view

(cherry picked from commit 3eaa781)
Service-Card-Id: 86390068
Service-Version: 1.15
DHowett pushed a commit that referenced this pull request Dec 1, 2022
## Summary of the Pull Request
This removes all of the redundant tooltips from the settings UI. Since all of the settings are added through the SettingsContainer, it's a pretty simple change.

Closes #14184

## Validation Steps Performed
- [X] hover over all settings in the settings UI
- [X] hover over all entries in the SUI nav view

(cherry picked from commit 3eaa781)
Service-Card-Id: 86390069
Service-Version: 1.16
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.16 Servicing Pipeline Dec 1, 2022
@DHowett DHowett moved this from Cherry Picked to Validated in 1.15 Servicing Pipeline Dec 13, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal v1.15.3465.0 and v1.15.3466.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
No open projects
4 participants