Ensure reading the buffer content actually returns the content

[ianjoneill]

Summary of the Pull Request

Ensures that reading the buffer content actually returns the content.

References

Regressed in #13626.

PR Checklist

• Closes Buffer exports only contain spaces #14378
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed

Validation Steps Performed

Added a test.

[ianjoneill]

The CI hates me.

Error: Verify: IsLessThan(tries, 5): Make sure we set up the new console in time - Values (5, 5) [File: C:\a\_work\1\s\src\host\ft_host\InitTests.cpp, Function: ModuleSetup, Line: 280]
Error: TAEF: Setup fixture 'ModuleSetup' for the scope 'C:\a\_work\1\a\drop\Release\x64\test\ConHost.Feature.Tests.dll' failed.

[zadjii-msft]

❤️

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 53 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[DHowett]

Sheesh good catch!

[lhecker]

oof... Thanks for catching this!

GetText() is now returning a wstring_view which doesn't have the previous replace() member function. So I checked all other callers of GetText() in #13626 and fortunately this was the only code that had any meaningful changes.

[ghost]

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download