Add the setting "confirmCloseAllTabs" to SUI

[leejy12]

This commit adds the setting "confirmCloseAllTabs" to SUI.
The setting was added to the Interactions pane of Global Settings.

Closes #14413
Closes #14033

[leejy12]

I think a better Header for the settings container is needed. Maybe a HelpText also.

[carlos-zamora]

FYI to reviewer, here's what it looks like:

[carlos-zamora]

Verified this works with screen readers.

Long-term, we need...

1. "don't show this again" checkboxes on the warning dialogs. When checked, we suppress the dialog and save the selection to state.json.
2. Migration (aka legacy support): if user has any warning settings set in settings.json, update state.json appropriately.
3. SUI updates:
   • add a UI for each warning so that the user can reset it.
   • add a "reset all warnings" button?

I'm saying all of this because adding these warnings to the SUI in the meantime shouldn't conflict with any of it. At the end of the day, if 1 and 2 is done, we just update the view model in SUI to update state.json instead of settings.json.

tl;dr: Thanks for doing this :). If you want to add all of the other warnings, go for it. Should be pretty much the same.

[zadjii-msft]

FWIW, Carlos's comment is largely musing and not indicative of work that NEEDS to be done in this PR. Small, incremental changes are always easier to review and ingest.

See also #6641

[carlos-zamora]

FWIW, Carlos's comment is largely musing and not indicative of work that NEEDS to be done in this PR. Small, incremental changes are always easier to review and ingest.

See also #6641

Sorry! Yes! Should've made that more clear haha. Just trying to be encouraging and give you (or anybody else) the direction we're thinking of going as a whole.

[ghost]

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[DHowett]

For clarity this might be better stated as, "Confirm when closing more than one tab". We cannot always translate the JSON names directly to sentences 😄

EDIT: or even, "Prompt for confirmation before closing more than one tab"?

[ghost]

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download