Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a dark titlebar when we've requested dark theme #14536

Merged
75 commits merged into from
Jan 19, 2023

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Dec 12, 2022

This applies to "showTabsInTitlebar": false,. We literally never set that for the IslandWindow before, only ever the NCIW.

Closes #11589

update-titlebar-for-theme

For a dramatic example - here's the IW with mica enabled, in dark mode:

image

Theme json:

        {
            "name": "chonk",
            "tab":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
                "showCloseButton": "never"
            },
            "tabRow":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
            },
            "window":
            {
                "applicationTheme": "dark",
                "useMica": true
            }
        },

zadjii-msft and others added 30 commits September 6, 2022 06:34
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worry about white flash

src/cascadia/WindowsTerminal/IslandWindow.cpp Outdated Show resolved Hide resolved
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 18, 2023
@DHowett
Copy link
Member

DHowett commented Jan 19, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DHowett DHowett removed their assignment Jan 19, 2023
@carlos-zamora
Copy link
Member

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 19, 2023
@ghost
Copy link

ghost commented Jan 19, 2023

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 19 Jan 2023 23:55:29 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett
Copy link
Member

DHowett commented Jan 19, 2023

@msftbot forget everything I just told you

@ghost
Copy link

ghost commented Jan 19, 2023

Hello @DHowett!

Because you've told me to reset the custom auto-merge settings, I'll use the configured settings for this repository when I'm merging this pull request.

@DHowett DHowett removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 19, 2023
@ghost ghost merged commit 79eb9b3 into main Jan 19, 2023
@ghost ghost deleted the dev/migrie/b/dark-titlebars-for-dark-theme branch January 19, 2023 23:51
@DHowett
Copy link
Member

DHowett commented Jan 19, 2023

(It might seem weird, but this is what i intended. 0 minutes instead of 5!)

@DHowett DHowett added this to To Cherry Pick in 1.16 Servicing Pipeline via automation Jan 19, 2023
@DHowett DHowett moved this from To Cherry Pick to Flighting, Consider Backport in 1.16 Servicing Pipeline Jan 19, 2023
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Theming Anything related to the theming of elements of the window Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
No open projects
1.16 Servicing Pipeline
Flighting, Consider Backport
Development

Successfully merging this pull request may close these issues.

Cause the title-bar to use the dark theme when tabs are disabled.
4 participants