Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically focus the ColorSchemeListView when we navigate to the ColorSchemes page #14631

Merged
3 commits merged into from
Jan 19, 2023
Merged

Automatically focus the ColorSchemeListView when we navigate to the ColorSchemes page #14631

3 commits merged into from
Jan 19, 2023

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jan 4, 2023 •
edited by DHowett
Loading

This regressed when we implemented ColorSchemeViewModel in #13179.
This commit fixes that by automatically focusing the ColorSchemeListView
when we navigate to the ColorSchemes page, which makes sense from a
user experience perspective anyway.

Closes #11971

carlos-zamora
carlos-zamora approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy Peasy Billy Butcher GIF

@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Jan 10, 2023
@ghost ghost added Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jan 11, 2023
carlos-zamora added a commit that referenced this pull request Jan 14, 2023
@carlos-zamora
PRE-MERGE #14631 Automatically focus the ColorSchemeListView when we …
ccef7f6 
…navigate to the ColorSchemes page
zadjii-msft
zadjii-msft approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to say in XAML "this is the thing that should start with focus"?

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 19, 2023
@ghost
Copy link

ghost commented Jan 19, 2023

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 96a9dd5 into main Jan 19, 2023
@ghost ghost deleted the dev/pabhoj/fix_regression branch January 19, 2023 23:21
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 24, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.17
4 participants
@PankajBhojwani @DHowett @carlos-zamora @zadjii-msft