Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Theme schema for 1.17 #14666

Merged
merged 7 commits into from
Jan 14, 2023
Merged

Update the Theme schema for 1.17 #14666

merged 7 commits into from
Jan 14, 2023

Conversation

zadjii-msft
Copy link
Member

What it says on the tin.

I finally figured out the right way to validate schema updates in VsCode, which made this a lot faster. Tossed notes in the wiki for next time I do this.

Closes #14560

@ghost ghost added Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Jan 11, 2023
DHowett
DHowett approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can I bother you for a version of this that is true to 1.16's theme code as well? :D

@zadjii-msft
Copy link
Member Author

whoops never hit send

image

@zadjii-msft
Copy link
Member Author

Thanks! Can I bother you for a version of this that is true to 1.16's theme code as well? :D

I think the only new thing is useMica so that should be easy

@zadjii-msft zadjii-msft mentioned this pull request Jan 12, 2023
Merged
DHowett pushed a commit that referenced this pull request Jan 13, 2023
@zadjii-msft
Add the Theme schema for 1.16 (#14672)
83d4009 
This is just #14666 ported to 1.16. Only diff is that useMica is removed. 

Related to #14560
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Jan 13, 2023
carlos-zamora
carlos-zamora approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I feel comfortable using themes haha. Thanks!

@carlos-zamora carlos-zamora merged commit 020746d into main Jan 14, 2023
@carlos-zamora carlos-zamora deleted the dev/migrie/s/theme-schema branch January 14, 2023 00:40
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal v1.16.1023 (10231 and 10232) has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 24, 2023
Closed
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.17] theme schema needs updating
3 participants
@zadjii-msft @DHowett @carlos-zamora