Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups after #14745 #14748

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Minor cleanups after #14745 #14748

merged 1 commit into from
Mar 30, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jan 27, 2023 •
edited
Loading

#14745 removed the only user of GetAugmentedOutputBuffer.

@lhecker lhecker added Product-Conhost For issues in the Console codebase Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Jan 27, 2023
Base automatically changed from dev/lhecker/8000-TranslateUnicodeToOem to main February 28, 2023 20:55
@lhecker lhecker marked this pull request as ready for review March 12, 2023 01:34
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone Mar 30, 2023
@zadjii-msft zadjii-msft merged commit da3a33f into main Mar 30, 2023
@zadjii-msft zadjii-msft deleted the dev/lhecker/8000-TranslateUnicodeToOem-cleanup branch March 30, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lhecker @DHowett @zadjii-msft