Fix a number of minor correctness issues that Clang flagged #14871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
added
the
Area-CodeHealth
zadjii-msft
approved these changes
Feb 17, 2023
lhecker
approved these changes
Feb 17, 2023
DHowett
added a commit
that referenced
this pull request
Sep 11, 2023
* `[[nodiscard]]` and `[[maybe_unused]]` must come before `virtual` and `static` qualifiers * We were calling the jsoncpp constructors directly (again) as functions (again) * Some of our preprocessor `#endif` lines were quite messed up (`-Winvalid-token`) * One of our test projects was using somebody else's `precomp.h` Related to #14871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lld-linkis more strict about the casing of keywords in.deffiles[[nodiscard]]must come beforevirtualandstaticqualifiersprecomp.his never to be included with<>KeyEvents by copy instead of directlyI don't know about the Dispatcher one, but it looks more correct this way. Also, it compiles. That was done before the C++/WinRT update, so maybe they fixed it as well.