Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Winget Releaser workflow #14965

Merged
merged 2 commits into from Mar 17, 2023
Merged

Add a Winget Releaser workflow #14965

merged 2 commits into from Mar 17, 2023

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Mar 8, 2023

The winget-releaser action automatically generates manifests for the
Winget Community Repository and submits them.

I suggest adding Dependabot to keep the action up to date. There were
many cases where the action was failing due to an outdated version.

Closes #14795

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. labels Mar 8, 2023
@zadjii-msft
Copy link
Member

Please ensure that the release tag matches the full package version of the msixbundle

OH BOY uh, that might be hard. We actually just switched away from doing that, because that was confusing. See #14106 for some discussion here. We may need to pursue the "Workflow with implementation of custom package version" option here

@sitiom
Copy link
Contributor Author

sitiom commented Mar 8, 2023

Hmm, extracting the full version from the release asset name would work too.

@sitiom
Copy link
Contributor Author

sitiom commented Mar 8, 2023

Hmm, extracting the full version from the release asset name would work too.

Done. The tag name shouldn't be a worry now.

@zadjii-msft
Copy link
Member

https://dev.azure.com/ms/terminal/_build/results?buildId=436098&view=logs&j=f3a2b39c-7194-5ef8-38f6-25d401474452&t=f15c8814-6a22-5381-efd1-6ff85efcd4b6&l=12300

    72>Done Building Project "C:\a\_work\1\s\src\cascadia\TerminalAzBridge\TerminalAzBridge.vcxproj" (build target(s)).
##[error]C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\DesktopBridge\Microsoft.DesktopBridge.targets(497,5): Error MSB4181: The "MSBuild" task returned false but did not log an error.
   100>C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\DesktopBridge\Microsoft.DesktopBridge.targets(497,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [C:\a\_work\1\s\src\cascadia\CascadiaPackage\CascadiaPackage.wapproj]
   100>Done Building Project "C:\a\_work\1\s\src\cascadia\CascadiaPackage\CascadiaPackage.wapproj" (default targets) -- FAILED.
     2>Done Building Project "C:\a\_work\1\s\src\cascadia\CascadiaPackage\CascadiaPackage.wapproj.metaproj" (default targets) -- FAILED.

Your PR should not have touched this at all... Something about our CI looks busted. I'll take a look

@sitiom
Copy link
Contributor Author

sitiom commented Mar 9, 2023

What did I touch? I just added a file 😅

@zadjii-msft
Copy link
Member

Nah no this wasn't you, this is the There is a circular dependency in the target dependency graph issue, #14581. I'll kick the build, it usually goes away after (a couple) retries

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msftbot make sure @DHowett signs off on this

@zadjii-msft
Copy link
Member

y'know "microsoft-github-policy-service" just doesn't roll off the tongue like msftbot did.

@microsoft-github-policy-service make sure @DHowett signs off on this

@DHowett
Copy link
Member

DHowett commented Mar 17, 2023

Moved notes from PR body


Before merging this:

  1. @DHowett Please create a classic PAT with public_repo scope and add it as here as a repository secret named WINGET_TOKEN.

example

  1. I also noticed https://github.com/DHowett/winget-pkgs is outdated. Please install Pull on the fork to ensure that it is kept up to date.

Additional Notes:

You can test out the action inputs in this playground.

If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been created with WinGet Releaser).

Validation Steps Performed

Tested the action inputs in the playground.


I'll take the to-do, and probably use the bot service account we have for it. Thanks so much for doing this!

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!

@DHowett DHowett changed the title Add Winget Releaser workflow Add a Winget Releaser workflow Mar 17, 2023
@DHowett DHowett merged commit bee22f3 into microsoft:main Mar 17, 2023
@sitiom sitiom deleted the winget-releaser branch March 18, 2023 01:19
@sitiom
Copy link
Contributor Author

sitiom commented Mar 18, 2023

I'll take the to-do, and probably use the bot service account we have for it. Thanks so much for doing this!

Don't forget to change the fork-user input to the bot account when you do so (or you probably should have done the prerequisites before merging this).

@DHowett
Copy link
Member

DHowett commented Mar 18, 2023

HAHA OOPS. Thanks/sorry

DHowett pushed a commit that referenced this pull request May 29, 2023
[The winget-releaser action] automatically generates manifests for the
[Winget Community Repository] and submits them.

I suggest adding Dependabot to keep the action up to date. There were
many cases where the action was failing due to an outdated version.

Closes #14795

[The winget-releaser action]:
https://github.com/vedantmgoyal2009/winget-releaser
[Winget Community Repository]: https://github.com/microsoft/winget-pkgs

(cherry picked from commit bee22f3)

winget: use the correct fork-user

(cherry picked from commit e1079d8)

winget.yml: switch to manually using wingetcreate (#15023)

It was brought to my attention that we should be more restrictive in
which tasks we ovver a GitHub token to. Sorry!

With thanks to sitiom for the version parsing and the magic GitHub
action syntax incantation for determining what is a prerelease.

(cherry picked from commit 5a34d92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically submit winget packages when we release a new version
3 participants