New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Winget Releaser workflow #14965
Conversation
OH BOY uh, that might be hard. We actually just switched away from doing that, because that was confusing. See #14106 for some discussion here. We may need to pursue the "Workflow with implementation of custom package version" option here |
Hmm, extracting the full version from the release asset name would work too. |
Done. The tag name shouldn't be a worry now. |
Your PR should not have touched this at all... Something about our CI looks busted. I'll take a look |
What did I touch? I just added a file 😅 |
Nah no this wasn't you, this is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msftbot make sure @DHowett signs off on this
y'know "microsoft-github-policy-service" just doesn't roll off the tongue like msftbot did. @microsoft-github-policy-service make sure @DHowett signs off on this |
Moved notes from PR body Before merging this:
Additional Notes: You can test out the action inputs in this playground. If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been created with WinGet Releaser). Validation Steps PerformedTested the action inputs in the playground. I'll take the to-do, and probably use the bot service account we have for it. Thanks so much for doing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this!
Don't forget to change the |
HAHA OOPS. Thanks/sorry |
[The winget-releaser action] automatically generates manifests for the [Winget Community Repository] and submits them. I suggest adding Dependabot to keep the action up to date. There were many cases where the action was failing due to an outdated version. Closes #14795 [The winget-releaser action]: https://github.com/vedantmgoyal2009/winget-releaser [Winget Community Repository]: https://github.com/microsoft/winget-pkgs (cherry picked from commit bee22f3) winget: use the correct fork-user (cherry picked from commit e1079d8) winget.yml: switch to manually using wingetcreate (#15023) It was brought to my attention that we should be more restrictive in which tasks we ovver a GitHub token to. Sorry! With thanks to sitiom for the version parsing and the magic GitHub action syntax incantation for determining what is a prerelease. (cherry picked from commit 5a34d92)
The winget-releaser action automatically generates manifests for the
Winget Community Repository and submits them.
I suggest adding Dependabot to keep the action up to date. There were
many cases where the action was failing due to an outdated version.
Closes #14795