Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A first couple Suggestion UI nits #15848

Merged
merged 4 commits into from
Aug 24, 2023
Merged

A first couple Suggestion UI nits #15848

merged 4 commits into from
Aug 24, 2023

Conversation

zadjii-msft
Copy link
Member

Closes the active checkboxes in #15845. I'll leave that open till we get to the endgame, I'm sure more will show up.

Closes:

  • Accessibility tags all have CommandPalette_ strings 🤣
  • useCommandline should leave the cursor at the end of the input, not at the start
  • useCommandline, when bottom-up, should leave the last list item selected, not the first.
  • ^ Probably applies to any changes to the filter text when bottom up.

@DHowett DHowett merged commit 7a05501 into main Aug 24, 2023
17 checks passed
@DHowett DHowett deleted the dev/migrie/b/sxnui-polish-1 branch August 24, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zadjii-msft @DHowett @lhecker