New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: vcpkg #15855
base: main
Are you sure you want to change the base?
WIP: vcpkg #15855
Conversation
This moves the following dependencies over to vcpkg: - gsl (as ms-gsl 3.1.0) - fmt (at 7.1.3) - pcg - stb - wyhash (though we don't include the header) It relies on the built-in support for vcpkg in Visual Studio 2022 17.7.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d10a629
to
fb4979f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -113,4 +113,7 @@ | |||
<ForcedIncludeFiles>$(SolutionDir)\bin\$(Configuration)\inc\TilFeatureStaging.h;%(ForcedIncludeFiles)</ForcedIncludeFiles> | |||
</ClCompile> | |||
</ItemDefinitionGroup> | |||
|
|||
<!-- For C++ projects, bring in the vcpkg targets at the end --> | |||
<Import Project="$(VcpkgRoot)/scripts/buildsystems/msbuild/vcpkg.targets" Condition="'$(MSBuildProjectExtension)'=='.vcxproj'" /> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
Since we link everything statically, we don't need to copy anything. | ||
This saves running a powershell script for every project. | ||
--> | ||
<VcpkgApplocalDeps>false</VcpkgApplocalDeps> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
Since we link everything statically, we don't need to copy anything. | ||
This saves running a powershell script for every project. | ||
--> | ||
<VcpkgApplocalDeps>false</VcpkgApplocalDeps> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
<CAExcludePath>$(CAExcludePath);$(VcpkgInstalledDir)</CAExcludePath> | ||
</PropertyGroup> | ||
|
||
<Import Project="$(VcpkgRoot)/scripts/buildsystems/msbuild/vcpkg.props" Condition="'$(MSBuildProjectExtension)'=='.vcxproj'" /> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
This comment has been minimized.
This comment has been minimized.
…nifest # Conflicts: # OpenConsole.sln
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (2)Applocal Previously acknowledged words that are now absentAAAa Batang chcbpat CLUSTERMAP COLORMATRIX COLR DBlob dcompile DESTINATIONNAME dxguid FFrom GFEh gitmodules inputrc kcub kcud kcuf kcuu khome Mbxy Mip nto Pathto QUESTIONMARK reallocs reamapping Resequence RTFTo srv subresource Tpp tracelog TRIANGLESTRIP Uniscribe waitable WScript XColors xff XMFLOAT 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:microsoft/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/8271952597/attempts/1' Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (2257) from .github/actions/spelling/expect/04cdb9b77d6827c0202f51acd4205b017015bfff.txt
Consider adding them (in with:
extra_dictionaries:
cspell:swift/src/swift.txt
cspell:gaming-terms/dict/gaming-terms.txt
cspell:monkeyc/src/monkeyc_keywords.txt
cspell:cryptocurrencies/cryptocurrencies.txt
cspell:scala/dict/scala.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Errors (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
No description provided.