Use a different schema for each branding #15856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since we started writing the entire settings file out ourselves, we've had the opportunity to control which schema it uses. This is a quality-of-life improvement for Preview users, and might make life easier for Dev users as well. One thing to consider is whether, if building Terminal in Debug+Dev mode, we should substitute in a `file:///` path. That would make the _local_ dev experience way cooler and cost us practically nothing.
lhecker
approved these changes
Aug 21, 2023
DHowett
changed the title
DHowett
added
the
Needs-Discussion
microsoft-github-policy-service
bot
added
Issue-Docs
zadjii-msft
removed
the
Needs-Discussion
zadjii-msft
approved these changes
Aug 22, 2023
DHowett
added a commit
that referenced
this pull request
Aug 30, 2023
Switch the schema depending on the branding we're being built for Ever since we started writing the entire settings file out ourselves, we've had the opportunity to control which schema it uses. This is a quality-of-life improvement for Preview users, and might make life easier for Dev users as well. For Debug builds, it even switches over to a local `file://` path to the schema in the source directory! Closes #6601 (cherry picked from commit 333fcd8) Service-Card-Id: 90281511 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the schema depending on the branding we're being built for
Ever since we started writing the entire settings file out ourselves,
we've had the opportunity to control which schema it uses.
This is a quality-of-life improvement for Preview users, and might make
life easier for Dev users as well.
For Debug builds, it even switches over to a local
file://path tothe schema in the source directory!
Closes #6601