Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an openAbout action. #15990

Merged
merged 1 commit into from Sep 18, 2023
Merged

Add an openAbout action. #15990

merged 1 commit into from Sep 18, 2023

Conversation

zadjii-msft
Copy link
Member

Just as it says on the label.
Closes #15986

Just as it says on the label.
Closes #15986
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Sep 18, 2023
@@ -378,8 +378,12 @@
},
"ShortcutActionName": {
"enum": [
"addMark",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just sorted all these, since they seemed 90% sorted already

@DHowett
Copy link
Member

DHowett commented Sep 18, 2023

nit: reword title to be in imperative form

@zadjii-msft zadjii-msft changed the title Adds an openAbout action. Add an openAbout action. Sep 18, 2023
@zadjii-msft zadjii-msft merged commit 8daf89e into main Sep 18, 2023
17 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/f/15986-openAbout branch September 18, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[About]: User is unable to assign any shortcut to activate 'About' button.
3 participants