Add Auto Prop Name to 'Delete Color Scheme' button #15994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
zadjii-msft
approved these changes
Sep 19, 2023
lhecker
approved these changes
Sep 19, 2023
DHowett
pushed a commit
that referenced
this pull request
Sep 22, 2023
Since the "delete color scheme" button is filled with an icon and a Text Box, the text is not automatically exposed as the autoProp.Name for the button. We have to do it manually just like we do for "delete profile". Validated manually using accessibility insights Closes #15984 (cherry picked from commit 3550e19) Service-Card-Id: 90584974 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the "delete color scheme" button is filled with an icon and a Text Box, the text is not automatically exposed as the autoProp.Name for the button. We have to do it manually just like we do for "delete profile".
Validated manually using accessibility insights
Closes #15984