Fix a crash in the GenerateName for SearchForTextArgs
#16054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
reviewed
Sep 28, 2023
| fmt::format(std::wstring_view(RS_(L"SearchForTextCommandKey")), | ||
| Windows::Foundation::Uri(QueryUrl()).Domain().c_str()) | ||
| }; | ||
| if (QueryUrl().empty()) |
There was a problem hiding this comment.
I'm confused… Isn't this supposed to be if (QueryUrl())?
(If it is: You can use if (const auto queryUrl = QueryUrl()) here.)
There was a problem hiding this comment.
nah cause like, the first branch is for "the user didn't provide a queryUrl, so let's just display this action with the default name".
lhecker
approved these changes
Sep 29, 2023
carlos-zamora
approved these changes
Oct 3, 2023
DHowett
approved these changes
Oct 3, 2023
DHowett
pushed a commit
that referenced
this pull request
Oct 3, 2023
Fixes MSFT:46725264 don't explode trying to parse a URL, if the string wasn't one. (cherry picked from commit 59aaba7) Service-Card-Id: 90687770 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MSFT:46725264
don't explode trying to parse a URL, if the string wasn't one.