Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss "Failed to reload settings" modals when settings.json is valid #16119

Merged
merged 1 commit into from Oct 11, 2023
Merged

Dismiss "Failed to reload settings" modals when settings.json is valid #16119

merged 1 commit into from Oct 11, 2023

Conversation

codecruisedor
Copy link
Contributor

Have added a conditional check in TerminalWindow::UpdateSettings method

PR Checklist

@codecruisedor
Update TerminalWindow::UpdateSettings
c3f20d4 
have added a conditional check in UpdateSettings method
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Oct 9, 2023
@zadjii-msft zadjii-msft merged commit af8e20c into microsoft:main Oct 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically dismiss "Failed to reload settings" modals when settings.json is valid
3 participants
@codecruisedor @lhecker @zadjii-msft