Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rectangular clipboard copying initiated from the app menu #16197

Merged
merged 1 commit into from Oct 20, 2023
Merged

Fix rectangular clipboard copying initiated from the app menu #16197

merged 1 commit into from Oct 20, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Oct 19, 2023 •
edited

cd6b083 had 2 issues:

  • Improper testing with Ctrl+M instead of Edit > Mark.
  • Wrong SelectionState function being used. When the selection is
    initiated without keyboard or mouse, IsKeyboardMarkSelection
    returns false. The proper function to use is IsLineSelection.

Closes #15153

Validation Steps Performed

  • Run Far
  • Start selection via Edit>Mark
  • Hold Alt while dragging to make a rectangular selection
  • Right click
  • Clipboard contains a rectangular copy ✅

@lhecker lhecker added this to To Cherry Pick in 1.19 Servicing Pipeline via automation Oct 19, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Oct 19, 2023
@DHowett DHowett enabled auto-merge (squash) October 19, 2023 20:43
@DHowett DHowett merged commit d496a5f into main Oct 20, 2023
17 checks passed
@DHowett DHowett deleted the dev/lhecker/15153-fixup branch October 20, 2023 16:10
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.19 Servicing Pipeline Oct 26, 2023
DHowett pushed a commit that referenced this pull request Oct 26, 2023
@lhecker @DHowett
Fix rectangular clipboard copying initiated from the app menu (#16197)
798ab58 
cd6b083 had 2 issues:
* Improper testing with Ctrl+M instead of Edit > Mark.
* Wrong SelectionState function being used. When the selection is
  initiated without keyboard or mouse, `IsKeyboardMarkSelection`
  returns false. The proper function to use is `IsLineSelection`.

Closes #15153

## Validation Steps Performed
* Run Far
* Start selection via Edit>Mark
* Hold Alt while dragging to make a rectangular selection
* Right click
* Clipboard contains a rectangular copy ✅

(cherry picked from commit d496a5f)
Service-Card-Id: 90886368
Service-Version: 1.19
@adonis-jimenez adonis-jimenez mentioned this pull request Nov 18, 2023
Closed
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.19 Servicing Pipeline Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
1.19 Servicing Pipeline
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected block is copied as one line into clipboard
3 participants
@lhecker @DHowett @zadjii-msft