Update Azure Cloud Shell for their new URI format #16247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/pabhoj/cloud_shell_fix
PankajBhojwani
commented
Oct 31, 2023
| @@ -398,6 +398,7 @@ namespace winrt::Microsoft::Terminal::TerminalConnection::implementation | |||
|
|
|||
| switch (bufferType) | |||
| { | |||
| case WINHTTP_WEB_SOCKET_BINARY_MESSAGE_BUFFER_TYPE: | |||
There was a problem hiding this comment.
The bufferType they return seems to have changed to BINARY_MESSAGE_BUFFER_TYPE, just adding that case here seems to work fine, not sure if this has other implications though
This comment has been minimized.
This comment has been minimized.
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Oct 31, 2023
zadjii-msft
approved these changes
Oct 31, 2023
lhecker
reviewed
Nov 1, 2023
lhecker
requested changes
Nov 1, 2023
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
lhecker
reviewed
Nov 7, 2023
lhecker
approved these changes
Nov 7, 2023
DHowett
requested changes
Nov 7, 2023
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Nov 8, 2023
DHowett
changed the title
radu-cernatescu
pushed a commit
to radu-cernatescu/terminal
that referenced
this pull request
Nov 8, 2023
The Azure cloud shell team made some API changes that required us to format our requests a little differently. This PR makes those changes (more info in the comments in the code) Closes microsoft#16098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure cloud shell team made some API changes that required us to format our requests a little differently. This PR makes those changes (more info in the comments in the code)
Closes #16098