Remove conhost telemetry #16253
Merged
Remove conhost telemetry #16253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
zadjii-msft
approved these changes
Nov 2, 2023
DHowett
requested changes
Nov 2, 2023
| @@ -428,11 +428,6 @@ HRESULT ConsoleCreateIoThread(_In_ HANDLE Server, | |||
| [[maybe_unused]] PCONSOLE_API_MSG connectMessage) | |||
| try | |||
| { | |||
| // Create a telemetry instance here - this singleton is responsible for | |||
| // setting up the g_hConhostV2EventTraceProvider, which is otherwise not | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
So... about that TraceLoggingRegister call...
mhm
src/server/ApiDispatchers.cpp
Outdated
| break; | ||
| case CONSOLE_REAL_UNICODE: | ||
| case CONSOLE_FALSE_UNICODE: | ||
| Telemetry::Instance().LogApiCall(Telemetry::ApiCall::ReadConsoleOutputCharacter, true); | ||
| break; | ||
| } | ||
|
|
There was a problem hiding this comment.
wait somebody's gonna find this in the future and choke on their Soylent
switch (a->StringType)
{
case 1:
break;
case 2:
break;
case 3:
break;
}complicated no-op. it keeps our enemies off our trail
src/server/ApiDispatchers.cpp
Outdated
| @@ -428,14 +419,11 @@ static DWORD TraceGetThreadId(CONSOLE_API_MSG* const m) | |||
| switch (a->ElementType) | |||
| { | |||
| case CONSOLE_ATTRIBUTE: | |||
src/server/ApiDispatchers.cpp
Outdated
| } | ||
| else | ||
| { | ||
| Telemetry::Instance().LogApiCall(Telemetry::ApiCall::ReadConsoleInput, a->Unicode); | ||
| } |
There was a problem hiding this comment.
rolling on the floor at this point
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
DHowett
approved these changes
Nov 3, 2023
lhecker
added
the
AutoMerge
radu-cernatescu
pushed a commit
to radu-cernatescu/terminal
that referenced
this pull request
Nov 8, 2023
The `Telemetry` class was implemented as a singleton which stood in my long-term goal to remove all global variables from the project. Most telemetry captured by it hasn't been looked at for a long time and just as much is now pointless (e.g.,`_fCtrlPgUpPgDnUsed`). This removes the code. ## Validation Steps Performed * Still compiles ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Telemetryclass was implemented as a singleton which stood inmy long-term goal to remove all global variables from the project.
Most telemetry captured by it hasn't been looked at for a long time
and just as much is now pointless (e.g.,
_fCtrlPgUpPgDnUsed).This removes the code.
Validation Steps Performed