Fix a coroutine AV crash #16412
Merged
Fix a coroutine AV crash #16412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Priority-1
DHowett
approved these changes
Dec 4, 2023
zadjii-msft
approved these changes
Dec 4, 2023
|
I did try to find other instances of lambdas-that-are-coroutines but couldn't. I believe these were the only ones, thankfully! |
DHowett
pushed a commit
that referenced
this pull request
Dec 4, 2023
tl;dr: A coroutine lambda does not hold onto captured variables. This causes an AV crash when closing tabs. I randomly noticed this in a Debug build as the memory contents got replaced with 0xCD. In a Release build this bug is probably fairly subtle and not common. (cherry picked from commit 91fd7d0) Service-Card-Id: 91258717 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this pull request
Jan 26, 2024
tl;dr: A coroutine lambda does not hold onto captured variables. This causes an AV crash when closing tabs. I randomly noticed this in a Debug build as the memory contents got replaced with 0xCD. In a Release build this bug is probably fairly subtle and not common. (cherry picked from commit 91fd7d0) Service-Card-Id: 91258716 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: A coroutine lambda does not hold onto captured variables.
This causes an AV crash when closing tabs. I randomly noticed this
in a Debug build as the memory contents got replaced with 0xCD.
In a Release build this bug is probably fairly subtle and not common.