Add missing TraceLoggingRegister calls #16467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conhost
DHowett
approved these changes
Dec 13, 2023
src/host/tracing.cpp
Outdated
| TraceLoggingOptionMicrosoftTelemetry()); | ||
|
|
||
| static const auto cleanup = []() { | ||
| TraceLoggingRegister(g_hConhostV2EventTraceProvider); |
There was a problem hiding this comment.
can we not register this in WinMain()? Since we're inside host and all.
There was a problem hiding this comment.
We could do that! I assume you would prefer that?
There was a problem hiding this comment.
feels less "weird", but for no good reason.
DHowett
approved these changes
Dec 13, 2023
PankajBhojwani
approved these changes
Dec 15, 2023
|
Unfortunately, this has exploded Audit Mode |
DHowett
approved these changes
Dec 15, 2023
DHowett
pushed a commit
that referenced
this pull request
Jan 29, 2024
17cc109 and e9de646 both made the same mistake: When cleaning up our telemetry code they also removed the calls to `TraceLoggingRegister` which also broke regular tracing. Windows Defender in particular uses the "CookedRead" event to monitor for malicious shell commands. This doesn't fix it the "right way", because destructors of statics aren't executed when DLLs are unloaded. But I felt like that this is fine because we have way more statics than that in conhost land, all of which have the same kind of issue. (cherry picked from commit a65d5f3) Service-Card-Id: 91337330 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
17cc109 and e9de646 both made the same mistake: When cleaning up our
telemetry code they also removed the calls to
TraceLoggingRegisterwhich also broke regular tracing. Windows Defender in particular uses
the "CookedRead" event to monitor for malicious shell commands.
This doesn't fix it the "right way", because destructors of statics
aren't executed when DLLs are unloaded. But I felt like that this is
fine because we have way more statics than that in conhost land,
all of which have the same kind of issue.