Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase VtInputThread buffer size #16470

Merged
merged 1 commit into from Dec 15, 2023
Merged

Increase VtInputThread buffer size #16470

merged 1 commit into from Dec 15, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Dec 13, 2023

This makes 3 improvements:

  • 16x larger input buffer size improves behavior when pasting
    clipboard contents while the win32-input-mode is enabled,
    as each input character is roughly 15-20x longer after encoding.
  • Translate UTF8 to UTF16 outside of the console lock.
  • Preserve the UTF16 buffer between reads for less mallocs.

@lhecker lhecker added Product-Conpty For console issues specifically related to conpty Area-Quality Stability, Performance, Etc. labels Dec 13, 2023
@DHowett DHowett added this to To Cherry Pick in 1.19 Servicing Pipeline via automation Dec 14, 2023
@DHowett DHowett merged commit 171a21a into main Dec 15, 2023
20 checks passed
@DHowett DHowett deleted the dev/lhecker/vt-buffer-size branch December 15, 2023 19:17
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.19 Servicing Pipeline Dec 15, 2023
DHowett pushed a commit that referenced this pull request Dec 15, 2023
@lhecker @DHowett
Increase VtInputThread buffer size (#16470)
91e97c1 
This makes 3 improvements:
* 16x larger input buffer size improves behavior when pasting
  clipboard contents while the win32-input-mode is enabled,
  as each input character is roughly 15-20x longer after encoding.
* Translate UTF8 to UTF16 outside of the console lock.
* Preserve the UTF16 buffer between reads for less mallocs.

(cherry picked from commit 171a21a)
Service-Card-Id: 91347494
Service-Version: 1.19
@DHowett DHowett moved this from Cherry Picked to Validated in 1.19 Servicing Pipeline Feb 21, 2024
@DHowett DHowett moved this from Validated to Shipped in 1.19 Servicing Pipeline Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

Assignees
No one assigned
Labels
Area-Quality Stability, Performance, Etc. Product-Conpty For console issues specifically related to conpty
Projects
1.19 Servicing Pipeline
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lhecker @DHowett @PankajBhojwani