Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SUI Color Scheme colors' AutoProp.Name and ToolTip #16544

Merged
merged 3 commits into from Jan 10, 2024

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

In the Settings UI's Color Scheme page (where you edit the color scheme itself), update the color chip buttons to include the RGB value in the tooltip and screen reader announcements.

Closes #15985
Closes #15983

Validation Steps Performed

Tooltip and screen reader announcement is updated on launch and when a new value is selected.

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Jan 8, 2024
@carlos-zamora
Copy link
Member Author

Displayed text says "Bright black RGB(118, 118, 118)"

@carlos-zamora carlos-zamora merged commit 057183b into main Jan 10, 2024
20 checks passed
@carlos-zamora carlos-zamora deleted the dev/cazamor/a11y/color-scheme-chip branch January 10, 2024 18:06
@DHowett DHowett added this to To Cherry Pick in 1.18 Servicing Pipeline via automation Jan 25, 2024
@DHowett DHowett added this to To Cherry Pick in 1.19 Servicing Pipeline via automation Jan 25, 2024
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.18 Servicing Pipeline Jan 25, 2024
DHowett pushed a commit that referenced this pull request Jan 25, 2024
In the Settings UI's Color Scheme page (where you edit the color scheme itself), update the color chip buttons to include the RGB value in the tooltip and screen reader announcements.

Closes #15985
Closes #15983

## Validation Steps Performed
Tooltip and screen reader announcement is updated on launch and when a new value is selected.

(cherry picked from commit 057183b)
Service-Card-Id: 91642734
Service-Version: 1.18
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.19 Servicing Pipeline Jan 25, 2024
DHowett pushed a commit that referenced this pull request Jan 25, 2024
In the Settings UI's Color Scheme page (where you edit the color scheme itself), update the color chip buttons to include the RGB value in the tooltip and screen reader announcements.

Closes #15985
Closes #15983

## Validation Steps Performed
Tooltip and screen reader announcement is updated on launch and when a new value is selected.

(cherry picked from commit 057183b)
Service-Card-Id: 91642735
Service-Version: 1.19
@DHowett DHowett moved this from Cherry Picked to Validated in 1.19 Servicing Pipeline Feb 21, 2024
@DHowett DHowett moved this from Validated to Shipped in 1.19 Servicing Pipeline Feb 21, 2024
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.18 Servicing Pipeline Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
3 participants