New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SUI Color Scheme colors' AutoProp.Name and ToolTip #16544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Area-Accessibility
Issues related to accessibility
Product-Terminal
The new Windows Terminal.
labels
Jan 8, 2024
lhecker
approved these changes
Jan 9, 2024
zadjii-msft
approved these changes
Jan 9, 2024
DHowett
pushed a commit
that referenced
this pull request
Jan 25, 2024
In the Settings UI's Color Scheme page (where you edit the color scheme itself), update the color chip buttons to include the RGB value in the tooltip and screen reader announcements. Closes #15985 Closes #15983 ## Validation Steps Performed Tooltip and screen reader announcement is updated on launch and when a new value is selected. (cherry picked from commit 057183b) Service-Card-Id: 91642734 Service-Version: 1.18
DHowett
pushed a commit
that referenced
this pull request
Jan 25, 2024
In the Settings UI's Color Scheme page (where you edit the color scheme itself), update the color chip buttons to include the RGB value in the tooltip and screen reader announcements. Closes #15985 Closes #15983 ## Validation Steps Performed Tooltip and screen reader announcement is updated on launch and when a new value is selected. (cherry picked from commit 057183b) Service-Card-Id: 91642735 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Accessibility
Issues related to accessibility
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Terminal
The new Windows Terminal.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
In the Settings UI's Color Scheme page (where you edit the color scheme itself), update the color chip buttons to include the RGB value in the tooltip and screen reader announcements.
Closes #15985
Closes #15983
Validation Steps Performed
Tooltip and screen reader announcement is updated on launch and when a new value is selected.