Fix overlapping disclaimer text in Profiles' Defaults section #16602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharsnx
commented
Jan 25, 2024
| <!-- Control Preview --> | ||
| <Border MaxWidth="{StaticResource StandardControlMaxWidth}"> | ||
| <Border x:Name="ControlPreview" | ||
| Width="400" | ||
| Height="180" | ||
| Margin="0,0,0,12" | ||
| Margin="0,12,0,12" |
There was a problem hiding this comment.
The live profile demo container had an inconsistent gap in the top and bottom. (Too close to disclaimer text, too far from the main content)
To fix that I applied the same amount of margin on both the top and bottom. Lmk if this is not what we want to do.
lhecker
approved these changes
Jan 25, 2024
DHowett
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix overlapping disclaimer text in Profiles' Defaults section
While removing ScrollViewer from the subpages in the settings UI, the main Grid child element order was not preserved and as a result, the disclaimer text overlapped with the main content on the page.
To fix that we now apply (the lost)
Grid.Rowproperty on the parent StackPanel of the main content.Validation Steps Performed
PR Checklist