Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: add experimental.repositionCursorWithMouse #16652

Merged
merged 1 commit into from Feb 9, 2024

Conversation

sarim
Copy link
Contributor

@sarim sarim commented Feb 2, 2024

Summary of the Pull Request

Add experimental.repositionCursorWithMouse to profiles.schema.json. So when editing settings.json with vscode, it autocompletes and don't complain.

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Not really relevant, but how I found out this was missing: It was experimental.moveCursorWithMouse early in the feature implementation PR. I was in my personal list to check out the feature, finally I tried to test it today, couldn't make it work cause I was trying with moveCursorWithMouse. VScode also wasn't much help as experimental. autocomplete didn't contain this value. After looking over the PR thoroughly and the relevant docs PR I realized my mistake.

Validation Steps Performed

I set $schema to my patched one's url and vscode no longer complains about experimental.repositionCursorWithMouse. Autocompletes and also shows description on hover.

PR Checklist

  • Closes #xxx N/A
  • Tests added/passed N/A
  • Documentation updated N/A
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@DHowett DHowett added this to To Cherry Pick in 1.20 Servicing Pipeline via automation Feb 9, 2024
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@DHowett DHowett changed the title Add experimental.repositionCursorWithMouse to profiles.schema.json schema: add experimental.repositionCursorWithMouse Feb 9, 2024
@DHowett DHowett merged commit d3a18b9 into microsoft:main Feb 9, 2024
7 checks passed
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.20 Servicing Pipeline Feb 21, 2024
DHowett pushed a commit that referenced this pull request Feb 21, 2024
Add experimental.repositionCursorWithMouse to profiles.schema.json. So
when editing settings.json with vscode, it autocompletes and don't
complain.

(cherry picked from commit d3a18b9)
Service-Card-Id: 91808635
Service-Version: 1.20
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.20 Servicing Pipeline Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants