Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DECKPAM mode behind velocity #16675

Merged
merged 3 commits into from Feb 6, 2024
Merged

Conversation

zadjii-msft
Copy link
Member

DECKPAM originally tracked in #16506.
Support was added in #16511.
But turns out people didn't expect the Terminal to actually be like, compliant: #16654

This closes #16654 while we think over in #16672 how we want to solve this

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Input Related to input processing (key presses, mouse, etc.) Area-VT Virtual Terminal sequence support Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. labels Feb 6, 2024
src/features.xml Fixed Show fixed Hide fixed
src/terminal/input/terminalInput.cpp Fixed Show fixed Hide fixed
src/terminal/input/terminalInput.cpp Fixed Show fixed Hide fixed

This comment has been minimized.

@DHowett DHowett added this to To Cherry Pick in 1.19 Servicing Pipeline via automation Feb 6, 2024
@DHowett DHowett added this to To Cherry Pick in 1.20 Servicing Pipeline via automation Feb 6, 2024
@DHowett DHowett removed this from To Cherry Pick in 1.19 Servicing Pipeline Feb 6, 2024
@DHowett DHowett enabled auto-merge (squash) February 6, 2024 23:01
@DHowett DHowett merged commit 71efdcb into main Feb 6, 2024
21 of 22 checks passed
@DHowett DHowett deleted the dev/migrie/b/16654-disable-deckpam branch February 6, 2024 23:11
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.20 Servicing Pipeline Feb 21, 2024
DHowett pushed a commit that referenced this pull request Feb 21, 2024
DECKPAM originally tracked in #16506.
Support was added in #16511.
But turns out people didn't expect the Terminal to actually be like,
compliant: #16654

This closes #16654 while we think over in #16672 how we want to solve
this

(cherry picked from commit 71efdcb)
Service-Card-Id: 91781164
Service-Version: 1.20
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.20 Servicing Pipeline Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal.
Projects
Development

Successfully merging this pull request may close these issues.

Keyboard Issues with zsh: Keypad and Other Keys Not Functional.
3 participants