Remove the "set default terminal" banner #16873
Merged
+8
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everyone who cares to know, knows. Everyone who doesn't, has an annoying bar above all terminals
|
Since we can't delete keys from the enum mapper used in ApplicationState here, I chose to introduce a new key called I'll file a bug and replace the GH# placeholder |
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
changed the title
lhecker
approved these changes
Mar 14, 2024
|
I'm tempted to say we should only pull the defterm one. People hated the KB service one, but we also don't get complaints about it anymore. I'd bet that if we delete the warning, we're surely going to get people who's KB no worky once again. |
zadjii-msft
approved these changes
Mar 20, 2024
DHowett
changed the title
DHowett
added a commit
that referenced
this pull request
Mar 21, 2024
**Default Terminal**: Everyone who cares to know, knows. Everyone who doesn't, has an annoying bar above all terminals I had to introduce a workaround for the fact that unknown dismissed message keys in `state.json` result in Terminal exploding on launch. :grin: That's tracked in #16874. Closes #11930 (but not in the way you'd expect) (cherry picked from commit febfbeb) Service-Card-Id: 92139784 Service-Version: 1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Terminal: Everyone who cares to know, knows. Everyone who doesn't, has an annoying bar above all terminals
I had to introduce a workaround for the fact that unknown dismissed message keys in
state.jsonresult in Terminal exploding on launch. 😁 That's tracked in #16874.Closes #11930 (but not in the way you'd expect)