Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/rel: publish symbols using the internal symbol request API instead #16991

Merged
merged 6 commits into from Apr 2, 2024
Merged

ci/rel: publish symbols using the internal symbol request API instead #16991

merged 6 commits into from Apr 2, 2024

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Apr 1, 2024

Work is ongoing to remove individually-authenticated service accounts from some pipelines. This moves us closer to that goal.

Tested in Nightly 2403.28002.

@DHowett
Copy link
Member Author

DHowett commented Apr 1, 2024

Successful publication output (checked via PowerShell after the build completed):

requestName                                  : WindowsTerminal_1.21.871.0
expirationTime                               : 4/16/2024 6:57:54 PM
publishToInternalServer                      : True
publishToPublicServer                        : True
publishToInternalServerStatus                : 3
publishToInternalServerResult                : 1
publishToInternalServerFailureMessage        :
publishToPublicServerStatus                  : 3
publishToPublicServerResult                  : 1
publishToPublicServerFailureMessage          :
filesBlockedFromPublicServer                 : {}
filesPublishedAsPrivateSymbolsToPublicServer : {}

@DHowett DHowett added this to To Cherry Pick in 1.18 Servicing Pipeline via automation Apr 1, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 1, 2024
View reviewed changes
build/pipelines/templates-v2/job-publish-symbols-using-symbolrequestprod-api.yml
ScriptType: InlineScript
Inline: |-
$AzToken = (Get-AzAccessToken -ResourceUrl api://30471ccf-0966-45b9-a979-065dbedb24c1).Token
Write-Host "##vso[task.setvariable variable=SymbolAccessToken;issecret=true]$AzToken"

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[issecret](#security-tab) is not a recognized word. \(unrecognized-spelling\)
build/pipelines/templates-v2/pipeline-onebranch-full-release-build.yml
@@ -248,12 +252,13 @@
displayName: Publish
dependsOn: [Build]
jobs:
- template: ./build/pipelines/templates-v2/job-publish-symbols.yml@self
- template: ./build/pipelines/templates-v2/job-publish-symbols-using-symbolrequestprod-api.yml@self

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[symbolrequestprod](#security-tab) is not a recognized word. \(unrecognized-spelling\)
build/pipelines/templates-v2/job-publish-symbols-using-symbolrequestprod-api.yml
@@ -0,0 +1,117 @@
parameters:

Check failure

Code scanning / check-spelling

Check File Path

[symbolrequestprod](#security-tab) is not a recognized word. \(check-file-path\)
@DHowett DHowett added this to To Cherry Pick in 1.19 Servicing Pipeline via automation Apr 1, 2024
@DHowett DHowett added this to To Cherry Pick in 1.20 Servicing Pipeline via automation Apr 1, 2024
zadjii-msft
zadjii-msft approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@DHowett DHowett enabled auto-merge April 2, 2024 17:05
@DHowett DHowett added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 2bcbe6b Apr 2, 2024
20 checks passed
@DHowett DHowett deleted the dev/duhowett/symbol-publication-via-powershell-instead branch April 2, 2024 23:35
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.20 Servicing Pipeline Apr 16, 2024
DHowett added a commit that referenced this pull request Apr 16, 2024
@DHowett
ci/rel: publish symbols using the internal symbol request API instead (…
3cfd13d 
…#16991)

Work is ongoing to remove individually-authenticated service accounts
from some pipelines. This moves us closer to that goal.

Tested in Nightly 2403.28002.

(cherry picked from commit 2bcbe6b)
Service-Card-Id: 92239368
Service-Version: 1.20
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.19 Servicing Pipeline Apr 16, 2024
DHowett added a commit that referenced this pull request Apr 16, 2024
@DHowett
ci/rel: publish symbols using the internal symbol request API instead (…
c6c0b41 
…#16991)

Work is ongoing to remove individually-authenticated service accounts
from some pipelines. This moves us closer to that goal.

Tested in Nightly 2403.28002.

(cherry picked from commit 2bcbe6b)
Service-Card-Id: 92239367
Service-Version: 1.19
@zadjii-msft zadjii-msft mentioned this pull request May 1, 2024
Closed
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.20 Servicing Pipeline May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.18 Servicing Pipeline
To Cherry Pick
1.19 Servicing Pipeline
Cherry Picked
1.20 Servicing Pipeline
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DHowett @lhecker @zadjii-msft