Buffer Restore: Fix serializing >32KiB #17022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
lhecker
commented
Apr 5, 2024
| @@ -2375,7 +2375,7 @@ std::string TextBuffer::GenRTF(const CopyRequest& req, | |||
|
|
|||
| // \fsN: specifies font size in half-points. E.g. \fs20 results in a font | |||
| // size of 10 pts. That's why, font size is multiplied by 2 here. | |||
| fmt::format_to(std::back_inserter(contentBuilder), FMT_COMPILE("\\fs{}"), std::to_string(2 * fontHeightPoints)); | |||
| fmt::format_to(std::back_inserter(contentBuilder), FMT_COMPILE("\\fs{}"), 2 * fontHeightPoints); | |||
There was a problem hiding this comment.
FYI the type of fontHeightPoints is int, so there should be no difference in behavior here.
DHowett
approved these changes
Apr 5, 2024
|
Yup exactly. That's how you end up with a 62GB buffer.txt. 😄 |
zadjii-msft
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to
buffer.clear()after a write. Whoops.This includes 2 additional, smaller improvements that I just happened
to notice: The
GenRTFcode callsto_stringdespite usingfmt.