Introduce a Universal package for Windows Terminal #3236
Conversation
|
@ocalvo, did I break it apart to your satisfaction here? |
…AppLogic is the new home.
…ere to support universal launch).
… because winrt objects are magic.
…s way different. This adds a method to signal that to logic and apply the setting override.
… it'll use the CRT inside TerminalConnection (or its other consumers) instead of linking its own.
… on how CRT linking works for future reference. I'm sure this will come up again.
… window handle on title update.
miniksa
force-pushed
the
dev/miniksa/uwp
branch
from
a9a075a
to
72a13a1
Compare
| <Link>defaults.json</Link> | ||
| </Content> | ||
| </ItemGroup> | ||
| <!-- Reprint all content as Nones for Universal project type to include it in the resources --> |
There was a problem hiding this comment.
@DHowett-MSFT, this reprint as None and the DeploymentContent on every item are killing me, but it's the only way I could make it work. If you know some MSBuild shorthand to clean this up, we can do that before submit (as long as both projects still play nice with it.)
|
@ocalvo, that'll make it smaller for the top stuff, thanks! But the Universal project still won't accept a Content, only a None/Image/etc as something to pack into the package. (Where as the Centennial project only accepts the inverse: it will only pack a Content and not a None/Image/etc). |
We have resolved this issue for Xaml Islands and WAP project, please use this targets file in your main EXE project. |
src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj.filters
Outdated
Show resolved
Hide resolved
…sal in Audit because we're not auditing app yet.
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
…arounds. improve consistency of variable decl in applogic.h
6.0.0 is now the release build from last week. I talked to Oscar about it and there were some updates to how resources are packaged. |
|
@miniksa Ah okay, that makes sense. I assumed the minor version would have been bumped or something. |
miniksa
changed the title
…age identity to match proposed license information.
This PR creates a Universal entrypoint for the Windows Terminal solution in search of our goals to run everywhere, on all Windows platforms.
The Universal entrypoint is relatively straightforward and mostly just invokes the App without any of the other islands and win32 boilerplate required for the centennial route. The Universal project is also its own packaging project all in one and will emit a relevant APPX.
A few things were required to make this work correctly:
TerminalAppthat are not available in the core platform (or don't have an appropriate existing platform forwarder... do a loader snaps check)Some of those happened in other small PRs in the past week or two. They were relevant to this.
Note, this isn't useful as such yet. You can run the Terminal in this context and even get some of the shells to work. But they don't do a whole lot yet. Scoping which shells appear in the profiles list and only offering those that contextually make sense is future work.