Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually pass mouse wheel messages to TermControls #5131

Merged
20 commits merged into from
Apr 1, 2020
Merged

Manually pass mouse wheel messages to TermControls #5131

20 commits merged into from
Apr 1, 2020

Commits on Mar 24, 2020

  1. try naively passing the mouse event through, but that doesn't seem to… 

    … do the trick
    @zadjii
    zadjii committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    dae733a View commit details
    Browse the repository at this point in the history

  2. doing this the right way still isn't right

    @zadjii
    zadjii committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    892bc58 View commit details
    Browse the repository at this point in the history

  3. start working on manually plumbing the event through, but this feels … 

    …so very wrong
    @zadjii
    zadjii committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    b708a08 View commit details
    Browse the repository at this point in the history

  4. This is so dumb ; I love it 

      Just ask for the control underneath the mouse where it scrolled, and dispatch a scroll event to it if it matches the given interface.
    @zadjii-msft
    zadjii-msft committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    68ace1a View commit details
    Browse the repository at this point in the history

  5. Hey if your laptop's clock batttery is broken, you're going to have I… 

    …MMENSE PAIN trying to work on this project.

  This doesn't work, but it's taking me like 5x as long to do anything on this laptop
    @zadjii-msft
    zadjii-msft committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    7252ab6 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Boy this is such a dirty hack but hey it works

    @zadjii-msft
    zadjii-msft committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    b3da428 View commit details
    Browse the repository at this point in the history

  2. So very much code cleanup 

      Also for good measure, let's link this to #979
    @zadjii-msft
    zadjii-msft committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    cf9d172 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/b/979-hp… 

    …-touchBAD
    @zadjii-msft
    zadjii-msft committed Mar 26, 2020
    1 Configuration menu
    Copy the full SHA
    b5a6de3 View commit details
    Browse the repository at this point in the history

  2. runformat

    @zadjii-msft
    zadjii-msft committed Mar 26, 2020
    1 Configuration menu
    Copy the full SHA
    47f8591 View commit details
    Browse the repository at this point in the history

  3. Appease the spelling god?

    @zadjii-msft
    zadjii-msft committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    10cb133 View commit details
    Browse the repository at this point in the history

  4. fix the SA build

    @zadjii-msft
    zadjii-msft committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    52c94dc View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. this wasn't that scary

    @zadjii-msft
    zadjii-msft committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    6e33a0f View commit details
    Browse the repository at this point in the history

  2. this is a handy helper for converting between the two

    @zadjii-msft
    zadjii-msft committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c0ed7ea View commit details
    Browse the repository at this point in the history

  3. Some minor code cleanup to make things easier to read

    @zadjii-msft
    zadjii-msft committed Mar 27, 2020
    1 Configuration menu
    Copy the full SHA
    f3483c2 View commit details
    Browse the repository at this point in the history

  4. some last changes for making events relative to the control origin

    @zadjii-msft
    zadjii-msft committed Mar 27, 2020
    1 Configuration menu
    Copy the full SHA
    c7a1e77 View commit details
    Browse the repository at this point in the history

  5. good bot

    @zadjii-msft
    zadjii-msft committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0de39a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/b/979-hp… 

    …-touchBAD

# Conflicts:
#	src/inc/til/point.h
#	src/til/ut_til/PointTests.cpp
    @zadjii-msft
    zadjii-msft committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    216941a View commit details
    Browse the repository at this point in the history

  2. Wrap these exceptions up

    @zadjii-msft
    zadjii-msft committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    8c3e284 View commit details
    Browse the repository at this point in the history

  3. This wasn't supposed to be on this branch

    @zadjii-msft
    zadjii-msft committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    ff021e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Update src/cascadia/TerminalControl/TermControl.cpp 

    Co-Authored-By: Michael Niksa <miniksa@microsoft.com>
    @zadjii-msft @miniksa
    zadjii-msft and miniksa committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    10e7baa View commit details
    Browse the repository at this point in the history