Set tab title as early as possible

src/cascadia/TerminalApp/Tab.cpp

@@ -45,6 +45,7 @@ namespace winrt::TerminalApp::implementation
     void Tab::_MakeTabViewItem()
     {
         _tabViewItem = ::winrt::MUX::Controls::TabViewItem{};
+        _UpdateTitle();
     }
 
     // Method Description:

src/cascadia/TerminalControl/TermControl.cpp

@@ -98,6 +98,8 @@ namespace winrt::Microsoft::Terminal::TerminalControl::implementation
         auto inputFn = std::bind(&TermControl::_SendInputToConnection, this, std::placeholders::_1);
         _terminal->SetWriteInputCallback(inputFn);
 
+        _terminal->UpdateSettings(settings);
+
         // Subscribe to the connection's disconnected event and call our connection closed handlers.
         _connectionStateChangedRevoker = _connection.StateChanged(winrt::auto_revoke, [this](auto&& /*s*/, auto&& /*v*/) {
             _ConnectionStateChangedHandlers(*this, nullptr);

src/cascadia/TerminalCore/Terminal.cpp

@@ -92,11 +92,6 @@ void Terminal::CreateFromSettings(winrt::Microsoft::Terminal::Settings::ICoreSet
     Create(viewportSize, Utils::ClampToShortMax(settings.HistorySize(), 0), renderTarget);
 
     UpdateSettings(settings);
-
-    if (_suppressApplicationTitle)
-    {
-        _title = _startingTitle;
-    }
 }
 
 // Method Description:
@@ -130,9 +125,12 @@ void Terminal::UpdateSettings(winrt::Microsoft::Terminal::Settings::ICoreSetting
         break;
     }
 
-    _buffer->GetCursor().SetStyle(settings.CursorHeight(),
-                                  settings.CursorColor(),
-                                  cursorShape);
+    if (_buffer)
+    {
+        _buffer->GetCursor().SetStyle(settings.CursorHeight(),
+                                      settings.CursorColor(),
+                                      cursorShape);
+    }
 
     for (int i = 0; i < 16; i++)
     {

src/cascadia/TerminalCore/Terminal.hpp

@@ -205,7 +205,7 @@ class Microsoft::Terminal::Core::Terminal final :
     std::unique_ptr<::Microsoft::Console::VirtualTerminal::StateMachine> _stateMachine;
     std::unique_ptr<::Microsoft::Console::VirtualTerminal::TerminalInput> _terminalInput;
 
-    std::wstring _title;
+    std::optional<std::wstring> _title;
     std::wstring _startingTitle;
 
     std::array<COLORREF, XTERM_COLOR_TABLE_SIZE> _colorTable;

src/cascadia/TerminalCore/TerminalApi.cpp

@@ -409,10 +409,11 @@ CATCH_LOG_RETURN_FALSE()
 bool Terminal::SetWindowTitle(std::wstring_view title) noexcept
 try
 {
-    _title = _suppressApplicationTitle ? _startingTitle : title;
-
-    _pfnTitleChanged(_title);
-
+    if (!_suppressApplicationTitle)
+    {
+        _title.emplace(title);
+        _pfnTitleChanged(_title.value());
+    }
     return true;
 }
 CATCH_LOG_RETURN_FALSE()

src/cascadia/TerminalCore/terminalrenderdata.cpp

@@ -181,7 +181,11 @@ void Terminal::SelectNewRegion(const COORD coordStart, const COORD coordEnd)
 const std::wstring Terminal::GetConsoleTitle() const noexcept
 try
 {
-    return _title;
+    if (_title.has_value())
+    {
+        return _title.value();
+    }
+    return _startingTitle;
 }
 catch (...)
 {