Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closeOtherTabs, closeTabsAfter actions #7176

Merged
4 commits merged into from
Aug 6, 2020
Merged

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

Adds support for two actions, closeOtherTabs and closeTabsAfter. Both these actions accept an index parameter.

  • closeOtherTabs: Close tabs other than index
  • closeTabsAfter: Close tabs after index (This is also "Close tabs to the right")

References

PR Checklist

  • I work here
  • Tests added/passed
  • Requires documentation to be updated
  • We should file an issue for "add an index param to closeTab" to add similar support to the close tab action
  • We should file an issue for "make the index param to closeOtherTabs, closeTabsAfter optional" to make them both work on the active tab when there's no index provided

Validation Steps Performed

  • Verified that closing all tabs when I have the index'th tab selected works as expected
  • Verified that closing all tabs when I have a tab other than the index'th tab selected works as expected
  • Verified that closing tabs to the right when I have the index'th tab selected works as expected
  • Verified that closing tabs to the right when I have a tab other than the index'th tab selected works as expected
    • This one has one caveat: for whatever reason, if you run this action when the tab that's currently focused is before the index param, then the tabs will expand to fill the entire width of the tab row, until you mouse over them. Probably has something to do with tabs not resizing down until there's a mouse exit event.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 4, 2020
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 6, 2020
@ghost
Copy link

ghost commented Aug 6, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 0a30b85 into master Aug 6, 2020
@ghost ghost deleted the dev/migrie/f/close-tabs-actions branch August 6, 2020 21:47
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants