Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform user that holding alt opens a new pane #7866

Merged
merged 4 commits into from Oct 13, 2020
Merged

Inform user that holding alt opens a new pane #7866

merged 4 commits into from Oct 13, 2020

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

Adds a tooltip to the new tab button to let the user know that holding alt will open a new pane instead

PR Checklist

Validation Steps Performed

panetip

@ghost ghost added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 8, 2020
@PankajBhojwani
Copy link
Contributor Author

Paging @cinnamon-msft for advice on the text in the tooltip

@DHowett
Copy link
Member

DHowett commented Oct 8, 2020

should we converge the wording with the URL one? it's simple, and puts the keyboard shortcut first. alt+click to split the current window

@cinnamon-msft
Copy link
Contributor

should we converge the wording with the URL one? it's simple, and puts the keyboard shortcut first. alt+click to split the current window

I dig this, just with proper casing, so Alt+Click to split the current window

@DHowett
Copy link
Member

DHowett commented Oct 8, 2020

unfortunately we chose to do all lowercase for TC:

src\cascadia\TerminalControl\Resources\en-US\Resources.resw
179:    <value>ctrl+click to follow link</value>

@cinnamon-msft
Copy link
Contributor

unfortunately we chose to do all lowercase for TC:

src\cascadia\TerminalControl\Resources\en-US\Resources.resw
179:    <value>ctrl+click to follow link</value>

Want me to make a quick PR to fix these up? They should technically have the uppercase first letter.

@DHowett
Copy link
Member

DHowett commented Oct 8, 2020

sure. might cause a relocalization unfortunately!

@cinnamon-msft
Copy link
Contributor

We should also add tooltips to the profiles inside the dropdown with the same message.

@PankajBhojwani PankajBhojwani self-assigned this Oct 9, 2020
@cinnamon-msft cinnamon-msft mentioned this pull request Oct 12, 2020
Merged
6 tasks
DHowett
DHowett approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DHowett DHowett merged commit 8d12388 into master Oct 13, 2020
@DHowett DHowett deleted the dev/pabhoj/alt_pane_tip branch October 13, 2020 00:14
DHowett pushed a commit that referenced this pull request Oct 19, 2020
@PankajBhojwani @DHowett
Inform user that holding alt opens a new pane (#7866)
fd1afae 
Adds a tooltip to the new tab button and menu  to let the user know
that holding alt will open a new pane instead.

Fixes #7851

Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com>
(cherry picked from commit 8d12388)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 11, 2020
Closed
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

@PankajBhojwani PankajBhojwani

Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a hover tip to let user know that holding "Alt" opens profile in a new pane
4 participants
@PankajBhojwani @DHowett @cinnamon-msft @zadjii-msft