Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrollviewers to settings UI #7998

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add scrollviewers to settings UI #7998

merged 1 commit into from
Oct 22, 2020

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

This fixes the bug where the reset/save footer covers settings.

References

#1564

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

DHowett
DHowett approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, it's rare that we get something "for free" with xaml.

@DHowett
Copy link
Member

DHowett commented Oct 21, 2020

it's got four signoffs somebody just merge it instead of signing off some more

@DHowett DHowett merged commit 3b04ba9 into feature/settings-ui Oct 22, 2020
@DHowett DHowett deleted the cinnamon/settings-scrolling branch October 22, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@leonMSFT leonMSFT leonMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cinnamon-msft @DHowett @carlos-zamora @zadjii-msft @leonMSFT