Hook up the Settings UI JSON button #8059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonMSFT
commented
Oct 27, 2020
miniksa
approved these changes
Oct 27, 2020
|
Approved presuming you're gonna rev it once more with the Alt trick per Dustin's comment and be done there. |
DHowett
reviewed
Oct 27, 2020
DHowett
approved these changes
Oct 27, 2020
…lian/sui-open-json
…nal into dev/lelian/sui-open-json
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
34 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make the "Open JSON file" navigation view item in the Settings UI will open the user's settings file. Normally,
NavigationViewItemsraise their parent'sItemInvokedhandler, but when aNavViewItemis in theNavigationView.PaneFooter, it doesn't do that. So, we have to hook upOpenJson'sTappedandKeyDownhandler to detect both a tap event and the enter keydown events.References #1564