Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed on build error xcopy on localized machines #847

Merged
2 commits merged into from
May 17, 2019

Conversation

ChristianBoehm
Copy link
Contributor

@ChristianBoehm ChristianBoehm commented May 16, 2019

echo ( f | xcopy ) will not work, can get around with putting an '*' at the end, xcopy will treat then as file. This solutions builds
fine on DE German machine.

Summary of the Pull Request

References

PR Checklist

  • Closes On Build error xcopy on not english localized machines #507
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

echo ( f | xcopy ) will not work, can get around with putting an '*' at the end, xcopy will treat then as file. This solutions builds 
fine on DE German machine.
@mKay00
Copy link
Contributor

mKay00 commented May 16, 2019

So it is a fix for #507 and another version of #741. I don't know where we are now about this issue. I have a similar solution like you in my repo (mKay00@08e6039), but I deleted the echo | fpart, since it isn't needed with the asterisk. And the other files should be changed as well, if we use this solution.

@ChristianBoehm
Copy link
Contributor Author

well for me only src/cppwinrt.build.post.props line 29-30 and 36-37 were complaining and stoped for me building a working solution. The remaining usage of xcopy under certain cmd files in the tools directory works perfect.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, #741 hasn't been bumped in a bit, so I'm inclined to take this over the other.

I would like to see the echo f | taken out of those commandlines though, if they're no longer needed.

set cmd switch to capital /Y from lower
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, but we'll need to close the other one then when this gets merged.

@mKay00
Copy link
Contributor

mKay00 commented May 16, 2019

I think that the other files should be changed the same way to be consistent and to prevent possible future issues.

@DHowett-MSFT DHowett-MSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 17, 2019
@ghost
Copy link

ghost commented May 17, 2019

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here.

@DHowett-MSFT DHowett-MSFT changed the title fixed on build error xcopy on localized machines #503 fixed on build error xcopy on localized machines May 17, 2019
@ghost ghost merged commit 2b41fad into microsoft:master May 17, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Build error xcopy on not english localized machines
5 participants