Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Microsoft.UI.Xaml 2.5 "stable" #8500

Merged
2 commits merged into from Dec 4, 2020
Merged

Update to Microsoft.UI.Xaml 2.5 "stable" #8500

2 commits merged into from Dec 4, 2020

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Dec 4, 2020

This commit moves us to the Xaml prerelease (201202003) that is
equivalent to public stable release 2.5.

Remember, we need to use prereleases for some silly reason.

This commit moves us to the Xaml prerelease (201202003) that is
equivalent to public stable release 2.5.

Remember, we need to use prereleases for some silly reason.
@DHowett
Copy link
Member Author

DHowett commented Dec 4, 2020

I'm testing this locally; wanted to kick off CI while I waited.

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@DHowett
Copy link
Member Author

DHowett commented Dec 4, 2020

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 4, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 04 Dec 2020 19:44:14 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett DHowett removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 4, 2020
@DHowett
Copy link
Member Author

DHowett commented Dec 4, 2020

Hold up, I've gotta remove that Compact tab sizing workaround!

@carlos-zamora
Copy link
Member

Does this let the Settings UI have a hierarchical view?

@DHowett
Copy link
Member Author

DHowett commented Dec 4, 2020

@carlos-zamora no. known XI deficiency.

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 4, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 50 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member Author

DHowett commented Dec 4, 2020

@msftbot merge this in 1 minute

@ghost
Copy link

ghost commented Dec 4, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 04 Dec 2020 23:47:58 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 87492c4 into main Dec 4, 2020
@ghost ghost deleted the dev/duhowett/new-xaml branch December 4, 2020 23:49
DHowett added a commit that referenced this pull request Jan 25, 2021
This commit moves us to the Xaml prerelease (201202003) that is
equivalent to public stable release 2.5.

Remember, we need to use prereleases for some silly reason.

(cherry picked from commit 87492c4)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants