Fix deserialization failure message of combined types

[Don-Vito]

PR Checklist

• Closes Numeric fontWeight is rejected by the profile parser #7690
• CLA signed.
• Tests added/passed
• Documentation updated.
• Schema updated.
• I've discussed this with core contributors already.

Validation Steps Performed

Manual tests

[DHowett]

So, for all of these except FontWeight, the boolean is not something I'd like to recommend to people. It's something we did for convenience, or something we did for compatibility (closeOnExit), but never recommended. I'd be more inclined to leave those ones alone.

For FontWeight, though. We're only adding the exception handling so that we can call our local TypeDescription, right?

It seems like FlagMapper and EnumMapper should just use TBase::TypeDescription. That will let them automatically get the derived type's description with automatic rollup to the parent's implementation. That way, you don't need to catch/rethrow/etc. 😄

[Don-Vito]

So, for all of these except FontWeight, the boolean is not something I'd like to recommend to people. It's something we did for convenience, or something we did for compatibility (closeOnExit), but never recommended. I'd be more inclined to leave those ones alone.

For FontWeight, though. We're only adding the exception handling so that we can call our local TypeDescription, right?

It seems like FlagMapper and EnumMapper should just use TBase::TypeDescription. That will let them automatically get the derived type's description with automatic rollup to the parent's implementation. That way, you don't need to catch/rethrow/etc. 😄

Actually, I wanted to make TypeDescription virtual. Do you see any problem with this?

[DHowett]

I'd rather we not do that -- right now it all compiles down to free immediate dispatch without vtable lookups... and we're not particularly helped by making it virtual (since there's workarounds here.)

The converter type never changes at runtime, which is the big thing virtual would let us do.

[Don-Vito]

I'd rather we not do that -- right now it all compiles down to free immediate dispatch without vtable lookups... and we're not particularly helped by making it virtual (since there's workarounds here.)

The converter type never changes at runtime, which is the big thing virtual would let us do.

Yeah. Makes sense. That is why I avoided it in the first place. 😊
I will try to call TBase.

[Don-Vito]

@DHowett - any reason TypeDescription is not static? I mean I can always do something like:

e.expectedType = static_cast<const TBase&>(*this).TypeDescription();

or to convert this method to static.

[DHowett]

Love this. Yeah, static thing is weird. I'm interested in cleaning up JsonUtils a little in the future, too. Got a couple todo list items in there 😄

[zadjii-msft]

Alright, seems cool to me. Thanks!

[zadjii-msft]

I'm gonna tag in @DHowett to massage the commit message and make sure that the build doesn't break on merging main

[DHowett]

Thanks!

[ghost]

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download